[Networking] Relaxes invalid message delivery penalty #5265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhassanzadeh13
changed the base branch from
master
to
yahya/6927-duplicate-ihave-topics
peterargue
approved these changes
Jan 22, 2024
kc1116
approved these changes
Jan 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5265 +/- ##
==========================================
- Coverage 55.44% 49.87% -5.57%
==========================================
Files 996 190 -806
Lines 95786 17043 -78743
==========================================
- Hits 53108 8501 -44607
+ Misses 38686 7951 -30735
+ Partials 3992 591 -3401
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yhassanzadeh13
added a commit
that referenced
this pull request
Jan 23, 2024
…veyr [Networking] Relaxes invalid message delivery penalty
yhassanzadeh13
added a commit
that referenced
this pull request
Jan 23, 2024
* Merge branch 'master' into yahya/relax-invalid-message-deliveyr * Revert "Merge branch 'master' into yahya/relax-invalid-message-deliveyr" This reverts commit a048b2c. * Merge pull request #5234 from onflow/yahya/6927-duplicate-ihave-topics [Networking] Enhance RPC Inspection with Configurable Thresholds and Granular Metrics Collection * Merge pull request #5265 from onflow/yahya/relax-invalid-message-deliveyr [Networking] Relaxes invalid message delivery penalty
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the default penalty for invalid message delivery in GossipSub, initially designed to counter integrity attacks. However, it was found that this penalty also applies to self-originated messages, regardless of their integrity. A known edge case in GossipSub can cause an increase in self-originated messages. This, combined with the high weight of invalid message delivery, can lead to false-positive severe penalties on nodes, potentially causing network partitioning. Therefore, we're adjusting these penalties to accommodate this edge case. Given that the penalty now encompasses both integrity violations and self-originated messages, we're moderating it to better reflect active, sustained attacks rather than occasional minor misbehaviors.