Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Fixes map-based backend concurrent adjust-with-init test #5275

Merged
merged 7 commits into from
Jan 24, 2024

Conversation

yhassanzadeh13
Copy link
Contributor

This PR resolves a concurrency issue in the map-based backend module's adjust-with-init test. The test's instability stemmed from the absence of defer in the waitgroup's Done method. Previously, the waitgroup was marked Done at the beginning rather than at the end of the goroutine, leading to an early evaluation of the cache's state.

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5ea8999) 55.57% compared to head (c6fc1d5) 55.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5275      +/-   ##
==========================================
+ Coverage   55.57%   55.62%   +0.04%     
==========================================
  Files        1003     1003              
  Lines       96785    96785              
==========================================
+ Hits        53791    53835      +44     
+ Misses      38919    38880      -39     
+ Partials     4075     4070       -5     
Flag Coverage Δ
unittests 55.62% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yhassanzadeh13 yhassanzadeh13 added this pull request to the merge queue Jan 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 24, 2024
@yhassanzadeh13 yhassanzadeh13 added this pull request to the merge queue Jan 24, 2024
Merged via the queue into master with commit 45cf91b Jan 24, 2024
51 checks passed
@yhassanzadeh13 yhassanzadeh13 deleted the yahya/fix-backend-test branch January 24, 2024 18:10
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants