Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move blockHash calculation after deduction supply diff #5464

Conversation

m-Peter
Copy link
Contributor

@m-Peter m-Peter commented Feb 27, 2024

Port of #5462 from feature/stable-cadence to master branch.

@m-Peter
Copy link
Contributor Author

m-Peter commented Feb 27, 2024

cc @ramtinms

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 56.03%. Comparing base (6908b7e) to head (bbe975b).

Files Patch % Lines
fvm/evm/handler/handler.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5464      +/-   ##
==========================================
- Coverage   56.06%   56.03%   -0.03%     
==========================================
  Files        1026     1026              
  Lines      100116   100116              
==========================================
- Hits        56129    56100      -29     
- Misses      39688    39711      +23     
- Partials     4299     4305       +6     
Flag Coverage Δ
unittests 56.03% <25.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janezpodhostnik janezpodhostnik added this pull request to the merge queue Feb 28, 2024
Merged via the queue into onflow:master with commit cd875cb Feb 28, 2024
50 of 51 checks passed
@m-Peter m-Peter deleted the port-fix-block-hash-inconsistency-to-master branch March 20, 2024 07:50
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants