Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Latest versions of core contracts #5517

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

joshuahannan
Copy link
Member

@joshuahannan joshuahannan commented Mar 6, 2024

  • Updates the versions core contracts to include the changes described in this forum post. This adds a conditional to not emit the FlowToken.TokensDeposited and FlowToken.TokensWithdrawn events if they are coming from the staking account on any networks. Some of the flow-go tests had to be updated to reflect this.

  • Includes the change to FungibleToken to make the Burner.Burnable.burnerCallback() function have a default implementation so that implementing it is optional.

None of these changes will be breaking for any contracts that rely on these

@joshuahannan joshuahannan changed the title Update to Latest versions of FungibleToken and FlowToken Update to Latest versions of core contracts Mar 6, 2024
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@turbolent turbolent requested review from a team and removed request for SupunS March 6, 2024 20:39
@turbolent turbolent merged commit e1f7a79 into feature/stable-cadence Mar 6, 2024
51 checks passed
@turbolent turbolent deleted the josh/update-core-contracts branch March 6, 2024 20:51
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants