Fix storage map key conversion in atree migration #5605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently storage map key is assumed to be StringAtreeValue type. However, storage domain cap_con uses Uint64AtreeValue as storage map key. This commit supports both map key types during atree migration and Cadence value validation.
|
@janezpodhostnik @turbolent PTAL 🙏 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5605 +/- ##
==========================================
- Coverage 55.65% 55.63% -0.03%
==========================================
Files 1037 1037
Lines 101377 101384 +7
==========================================
- Hits 56424 56405 -19
- Misses 40613 40636 +23
- Partials 4340 4343 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
turbolent
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Good catch!
For the Cadence 1.0 migration you can see the equivalent here: https://github.com/onflow/cadence/blob/468b11b79ff9c37a5d03e85fb49e6be012fd6ace/migrations/migration.go#L79-L104
janezpodhostnik
approved these changes
Apr 1, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
21 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently storage map key is assumed to be StringAtreeValue type. However, storage domain cap_con uses Uint64AtreeValue as storage map key.
This PR supports both map key types during atree migration and Cadence value validation.
This problem was found by using latest testnet data for atree migration + Cadence v0.42. Prior tests using mainnet data did not encounter this issue.