Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve migrations #5657

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Improve migrations #5657

merged 3 commits into from
Apr 16, 2024

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Apr 10, 2024

  • Remove unused AccountsAtreeLedger. It's from '21 and not used either by atree register inlining nor Cadence 1.0 migration
  • Improve comment
  • Generate set of all storage map domains from slice (ensure they are in sync)

@fxamacker @janezpodhostnik seeing AccountUsageMigrator made me wonder: I guess we also want to run this after the Cadence 1.0 migration, because it also changes account storage usage (even if just slightly)?

@turbolent turbolent self-assigned this Apr 10, 2024
@turbolent turbolent requested review from a team, fxamacker and janezpodhostnik April 10, 2024 22:49
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.64%. Comparing base (8afb152) to head (8a0839b).
Report is 970 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5657      +/-   ##
==========================================
+ Coverage   56.00%   57.64%   +1.63%     
==========================================
  Files        1024      834     -190     
  Lines       99327    78547   -20780     
==========================================
- Hits        55632    45281   -10351     
+ Misses      39455    29964    -9491     
+ Partials     4240     3302     -938     
Flag Coverage Δ
unittests 57.64% <ø> (+1.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janezpodhostnik
Copy link
Contributor

Ideally we would run AccountUsageMigrator last, so that we don't have to worry about updating storage used in the other migrations.

@turbolent turbolent added this pull request to the merge queue Apr 16, 2024
Merged via the queue into master with commit 17c153a Apr 16, 2024
55 checks passed
@turbolent turbolent deleted the bastian/improve-migrations branch April 16, 2024 21:38
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants