Log the checkpoint file when generating protocol snapshot #5679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
latest checkpoint file
zhangchiqing
commented
Apr 16, 2024
Comment on lines
+86
to
+89
| return commands.ConvertToMap(protocolSnapshotResponse{ | ||
| Snapshot: serializable.Encodable(), | ||
| Checkpoint: checkpointFile, | ||
| }) |
There was a problem hiding this comment.
Returning the snapshot along with the checkpoint file name.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5679 +/- ##
===========================================
+ Coverage 56.00% 77.55% +21.54%
===========================================
Files 1024 6 -1018
Lines 99327 392 -98935
===========================================
- Hits 55632 304 -55328
+ Misses 39455 71 -39384
+ Partials 4240 17 -4223
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jordanschalm
approved these changes
Apr 17, 2024
janezpodhostnik
approved these changes
Apr 17, 2024
zhangchiqing
deleted the
leo/read-protocol-state-snapshot-log-checkpoint-file
branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logs/return the checkpoint file to the admin tool when generating protocol snapshot from latest checkpoint. This allows us to know which checkpoint file is for the generated protocol snapshot file