Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Cadence v1.0.0-preview.22 #5775

Merged

Conversation

turbolent
Copy link
Member

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.09%. Comparing base (8e7bcf6) to head (8e7bcf6).

❗ Current head 8e7bcf6 differs from pull request most recent head da73c21. Consider uploading reports for the commit da73c21 to get more accurate results

Additional details and impacted files
@@                   Coverage Diff                   @@
##           feature/stable-cadence    #5775   +/-   ##
=======================================================
  Coverage                   47.09%   47.09%           
=======================================================
  Files                         164      164           
  Lines                       14470    14470           
=======================================================
  Hits                         6814     6814           
  Misses                       7179     7179           
  Partials                      477      477           
Flag Coverage Δ
unittests 47.09% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent turbolent requested review from a team April 24, 2024 20:38
@turbolent
Copy link
Member Author

turbolent commented Apr 24, 2024

Blocked on core contracts and standards getting updated to onflow/flips#242
Done in #5776. Thanks @joshuahannan!

@@ -1171,7 +1171,7 @@ func TestCoreContractUsage(t *testing.T) {
require.Equal(t, expected, actual)
})

t.Run("&NonFungibleToken.Collection => auth(Withdraw, Owner) &{NonFungibleToken.Collection}", func(t *testing.T) {
t.Run("&NonFungibleToken.Collection => auth(Withdraw | Owner) &{NonFungibleToken.Collection}", func(t *testing.T) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shows the new entitlements inference works

@turbolent turbolent merged commit 5646130 into feature/stable-cadence Apr 25, 2024
55 checks passed
@turbolent turbolent deleted the auto-update-onflow-cadence-v1.0.0-preview.22 branch April 25, 2024 00:09
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants