Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add static port for observer bind address in integration tests #5801

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

peterargue
Copy link
Contributor

@peterargue peterargue commented Apr 29, 2024

Occasionally, observers fail to start because of a port conflict while starting the network (Run):

container.go:219: testingdock: container start failure: Error response from daemon: driver failed programming external connectivity on endpoint observer_1 (eea0760122c76ba24b88f943b71079c312b5354c5d79fe3a309d5000a56de93f): Bind for 0.0.0.0:43343 failed: port is already allocated

There is likely a race condition/bug within testingdock where it doesn't synchronize the ports it allocates with those the OS allocates. Setting a fixed bind port should avoid this situation.

@sideninja sideninja self-requested a review April 29, 2024 13:28
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 55.69%. Comparing base (ed9f53f) to head (44e1252).

Files Patch % Lines
integration/testnet/network.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5801      +/-   ##
==========================================
+ Coverage   54.66%   55.69%   +1.03%     
==========================================
  Files         942     1094     +152     
  Lines       75331    85553   +10222     
==========================================
+ Hits        41177    47646    +6469     
- Misses      30089    33301    +3212     
- Partials     4065     4606     +541     
Flag Coverage Δ
unittests 55.69% <0.00%> (+1.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterargue peterargue added this pull request to the merge queue Apr 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 29, 2024
@sideninja sideninja added this pull request to the merge queue Apr 29, 2024
Merged via the queue into master with commit f634093 Apr 29, 2024
55 checks passed
@sideninja sideninja deleted the petera/fix-observer-bind-port-ci branch April 29, 2024 17:43
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants