Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pebble Refactor] Making finalization concurrent safe #6373

Conversation

zhangchiqing
Copy link
Member

@zhangchiqing zhangchiqing commented Aug 19, 2024

Working towards this

This PR makes both collection and consensus finalization concurrent safe by using locks.

Test cases passed:

go test --failfast --tags=relic -run=TestFinalizerPebble/concurrency_safety -count=100
PASS
ok      github.com/onflow/flow-go/module/finalizer/collection   119.160s


go test --failfast --tags=relic -run=TestMakeFinalConcurrencySafe -count=100
PASS
ok      github.com/onflow/flow-go/module/finalizer/consensus    28.351s

@zhangchiqing zhangchiqing changed the base branch from v0.33 to leo/v0.33-pebble-storage-to-review August 19, 2024 23:32
@zhangchiqing zhangchiqing marked this pull request as ready for review August 20, 2024 03:44
@zhangchiqing zhangchiqing merged commit 29d78d8 into leo/v0.33-pebble-storage-to-review Sep 13, 2024
51 checks passed
@zhangchiqing zhangchiqing deleted the leo/v0.33-pebble-storage-finalizing branch September 13, 2024 18:09
@zhangchiqing
Copy link
Member Author

Consolidate and merge all changes to leo/v0.33-pebble-storage-to-review. The changes in this PR can still be a reference.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant