Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Add registerDB pruning module #6397

Draft
wants to merge 35 commits into
base: master
Choose a base branch
from

Conversation

UlyanaAndrukhiv
Copy link
Contributor

Closes #6068

In this PR:

  • Implemented pruner module for registerDB which will ensure that unneeded pruned data is removed from the db, freeing up disk space.
  • Integrated pruner into Access and Observer nodes.
  • Added metrics.
  • Added functional tests .

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 34.68750% with 209 lines in your changes missing coverage. Please review.

Project coverage is 41.42%. Comparing base (2a443de) to head (fc4d6cb).

Files with missing lines Patch % Lines
cmd/access/node_builder/access_node_builder.go 0.00% 51 Missing ⚠️
cmd/observer/node_builder/observer_builder.go 0.00% 50 Missing ⚠️
module/metrics/registers_db_pruner.go 0.00% 50 Missing ⚠️
storage/pebble/registers_pruner.go 79.16% 16 Missing and 9 partials ⚠️
module/mock/register_db_pruner_metrics.go 0.00% 13 Missing ⚠️
module/mock/access_metrics.go 0.00% 8 Missing ⚠️
storage/pebble/operation/registers.go 0.00% 6 Missing ⚠️
module/metrics/access.go 0.00% 3 Missing ⚠️
module/metrics/noop.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6397      +/-   ##
==========================================
- Coverage   41.44%   41.42%   -0.02%     
==========================================
  Files        2026     2030       +4     
  Lines      144629   144906     +277     
==========================================
+ Hits        59937    60024      +87     
- Misses      78492    78666     +174     
- Partials     6200     6216      +16     
Flag Coverage Δ
unittests 41.42% <34.68%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

node.Logger,
builder.RegisterDB,
pstorage.WithPrunerMetrics(builder.RegisterDBPrunerMetrics),
//pstorage.WithPruneThreshold(builder.registerDBPruneThreshold),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WithPruneThreshold is temporarily commented out and will be re-enabled once PR #6345 is merged.

Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! I haven't finished reviewing everything, but here are my comments so far.

storage/pebble/registers_pruner.go Outdated Show resolved Hide resolved
storage/pebble/registers_pruner.go Outdated Show resolved Hide resolved
storage/pebble/registers_pruner.go Outdated Show resolved Hide resolved
storage/pebble/registers_pruner.go Outdated Show resolved Hide resolved
storage/pebble/registers_pruner.go Outdated Show resolved Hide resolved
storage/pebble/registers_pruner.go Outdated Show resolved Hide resolved
storage/pebble/registers_pruner.go Outdated Show resolved Hide resolved
storage/pebble/registers_pruner.go Outdated Show resolved Hide resolved
storage/pebble/registers_pruner.go Outdated Show resolved Hide resolved
storage/pebble/registers_pruner.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Access] Add registerDB pruning module
4 participants