-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] Add registerDB pruning module #6397
base: master
Are you sure you want to change the base?
[Access] Add registerDB pruning module #6397
Conversation
…ub.com:The-K-R-O-K/flow-go into UlyanaAndrukhiv/6068-registerDB-pruning-module
…ub.com:The-K-R-O-K/flow-go into UlyanaAndrukhiv/6068-registerDB-pruning-module
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6397 +/- ##
==========================================
- Coverage 41.44% 41.42% -0.02%
==========================================
Files 2026 2030 +4
Lines 144629 144906 +277
==========================================
+ Hits 59937 60024 +87
- Misses 78492 78666 +174
- Partials 6200 6216 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ub.com:The-K-R-O-K/flow-go into UlyanaAndrukhiv/6068-registerDB-pruning-module
node.Logger, | ||
builder.RegisterDB, | ||
pstorage.WithPrunerMetrics(builder.RegisterDBPrunerMetrics), | ||
//pstorage.WithPruneThreshold(builder.registerDBPruneThreshold), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WithPruneThreshold
is temporarily commented out and will be re-enabled once PR #6345 is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work! I haven't finished reviewing everything, but here are my comments so far.
…ling according to comments
…ore godoc for tests
Closes #6068
In this PR:
pruner
module forregisterDB
which will ensure that unneeded pruned data is removed from the db, freeing up disk space.pruner
into Access and Observer nodes.