[Util] Check checkpoint file exists when running state extraction #6459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangchiqing
requested review from
fxamacker,
turbolent and
janezpodhostnik
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6459 +/- ##
==========================================
- Coverage 41.65% 41.45% -0.21%
==========================================
Files 1974 2026 +52
Lines 139202 144611 +5409
==========================================
+ Hits 57985 59944 +1959
- Misses 75189 78468 +3279
- Partials 6028 6199 +171
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
janezpodhostnik
approved these changes
Sep 12, 2024
zhangchiqing
force-pushed
the
leo/util-ensure-checkpoint-exists
branch
from
a677314
to
24d820d
Compare
fxamacker
approved these changes
Sep 12, 2024
zhangchiqing
commented
Sep 12, 2024
|
|
||
| err := ensureCheckpointFileExist(flagExecutionStateDir) | ||
| if err != nil { | ||
| log.Error().Err(err).Msgf("cannot ensure checkpoint file exist in folder %v", flagExecutionStateDir) |
There was a problem hiding this comment.
Some test cases wants the checkpoint folder to be empty. Changed it from Fatal to Error for now.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running state extraction with a wrong
--execution-state-dirflag, the error message is misleading.This PR adds check to ensure checkpoint file can be found in the specified
--execution-state-dirand improved error message when a wrong or empty folder is used.