Include killed boolean in command result
#250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance we can get this PR considered? |
gustavohenke
requested changes
May 9, 2021
|
As far as I can tell there are no existing tests that test the exit condition of multiple commands in the |
|
OK, I figured it out. Been so long since I did this I had forgotten the structure of the project. |
gustavohenke
approved these changes
May 9, 2021
|
Do I have to do anything to merge this? I assume you'll merge it at some point. |
|
Any idea when this will be released? |
|
Heya. Just released it in v6.2.0. |
|
brilliant, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exit code of each command is already included in the result but the usefulness of this is limited if concurrently is run with
killOthers. When parsing the result you do not know if a non-0 exit code is because the command failed or if it was killed by concurrently.Adding this option allows you to print a message at the end identifying exactly which commands caused the initial failure.