[BB-3585] Add initial setup for e2e tests #707
Conversation
There was a problem hiding this comment.
@arjunsinghy96, the overall structure of the tests is looking alright, though they're quite flaky on circleci and I'm also having trouble running them locally at the moment.
Also these new tests aren't configured to run on CircleCI, or in the make test target. Should we be adding them there as well?
I can help configure circle.yml to run the e2e tests if it helps. Our circle.yml file for this project has a lot going on at this point.
We should just be able to add another workflow for the e2e tests.
--
I left a few requests for changes, specifically around the sleep calls in the tests.
One of the commit messages is incredibly long and duplicates of the same message as well. Since we'll squash commits before we merge, this isn't a huge deal as long as we change the message, but I just thought I should note it since it will clutter the git log view.
arjunsinghy96
force-pushed
the
arjun/bb-3585-e2e-setup
branch
18 times, most recently
from
2f17b8c
to
d6d5e72
Compare
|
Thanks for the updates @arjunsinghy96. I have one other comment and there's a merge conflict with dependencies from something else that must have merged in the meantime. Apart from the remaining comment this looks good. |
arjunsinghy96
force-pushed
the
arjun/bb-3585-e2e-setup
branch
3 times, most recently
from
1795fff
to
5608356
Compare
|
Thanks for the revisions @arjunsinghy96! This is looking good. 👍
|
Adds e2e_tests djangoapp with `e2e_test` command. Adds the utiliites for e2e tests Adds make command and e2e_tests app in INSTALLED_APPS requirements: Update selenium to 3.141.0 Add e2e tests in circle CI
arjunsinghy96
force-pushed
the
arjun/bb-3585-e2e-setup
branch
from
5608356
to
c66807b
Compare
This adds the base for e2e test in OCIM with react frontend
JIRA Tickets: BB-3585
Testing Instruction
vagrant upandvagrant sshto checkin into the devstack.make requirements./bin/install-supported-firefoxmake test.e2ee2e-testsis passing.Author Notes
3.141.0(added in requirements) and85+(updated in./bin/install-supported-firefox) respectivelyregistration.tests.utils.BrowserTestMixinusingseleniumbut I could not find its use anywhere.