-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactoring component structure #1044
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
✅ Deploy Preview for polite-licorice-3db33c canceled.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1044 +/- ##
==========================================
+ Coverage 71.87% 72.91% +1.03%
==========================================
Files 28 31 +3
Lines 2866 2865 -1
==========================================
+ Hits 2060 2089 +29
+ Misses 701 672 -29
+ Partials 105 104 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
thisthat
reviewed
Dec 1, 2023
Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com> Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Kavindu-Dodan
approved these changes
Dec 5, 2023
thisthat
approved these changes
Dec 6, 2023
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Merged
toddbaert
pushed a commit
that referenced
this pull request
Dec 22, 2023
This PR refactors the core package by restructuring the components responsible for managing the subscriptions, as well as the creation of sync sources. The following changes have been made:
sync-store
package tosubscriptions
. This has been done to avoid confusion because we already have async
, and astore
. package. Within the package, theSyncStore
. has been renamed tosubscriptions.Manager
, which should reflect its responsibility in a better way. Also, thesyncHandler
has been renamed tomultiplexer
, as this one is responsible for sending updates of a certain target to all subscribers -syncHandler
was a bit too generic in my opinion.GetSyncSourceFromURI
method to a new package,sync/builder
, to remove the responsibility of building concrete sync sources from the subscription managerruntime
package by calling the respective methods for the config retrieval provided by thesync/kubernetes
package and then handing that config back to the initialization of theK8sSync
. Note: This step can potentially be done in a separate PR, if so desired.