Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4330] Add unique constraint to group configs names #4532

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Jul 17, 2024

Partly closes #4330 (in preparation of using natural keys.

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.57%. Comparing base (b0feb8a) to head (89cdff6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4532   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files         719      719           
  Lines       24077    24077           
  Branches     2862     2862           
=======================================
  Hits        23253    23253           
  Misses        560      560           
  Partials      264      264           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding a unique slug field makes more sense than making names unique? My gut feeling says that names will not be a stable identity between versions of forms 🤔

This is also a breaking change, so a detection script for non-unique slugs would need to be added to make them fix the data before upgrading.

@sergei-maertens
Copy link
Member

Going to put this one back in draft so I stop looking at it!

@sergei-maertens sergei-maertens marked this pull request as draft July 23, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exporting a form from 'test' and importing on 'acceptance' leads to invalid URLs to informatieobjecttypes
2 participants