Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [#4653] Add blocks dropdown to TinyMCE toolbar (2.7.x backport) #4667

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Sep 16, 2024

this was implemented in 103e511, but that commit also introduces extra changes that we do not want to backport

partially closes #4653

Changes

  • Add blocks dropdown to TinyMCE toolbar

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

this was implemented in 103e511, but that commit also introduces extra changes that we do not want to backport
@stevenbal stevenbal force-pushed the backport/4653-tinymce-toolbar-options branch from 1df0900 to f3ae142 Compare September 16, 2024 14:14
@stevenbal stevenbal changed the title 🐛 [#4653] Add blocks dropdown to TinyMCE toolbar 🐛 [#4653] Add blocks dropdown to TinyMCE toolbar (backport) Sep 16, 2024
@stevenbal stevenbal changed the title 🐛 [#4653] Add blocks dropdown to TinyMCE toolbar (backport) 🐛 [#4653] Add blocks dropdown to TinyMCE toolbar (2.7.x backport) Sep 16, 2024
@stevenbal stevenbal linked an issue Sep 16, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.56%. Comparing base (c3ba281) to head (ccb51ee).
Report is 3 commits behind head on stable/2.7.x.

Additional details and impacted files
@@              Coverage Diff              @@
##           stable/2.7.x    #4667   +/-   ##
=============================================
  Coverage         96.56%   96.56%           
=============================================
  Files               719      719           
  Lines             24157    24157           
  Branches           2873     2873           
=============================================
  Hits              23328    23328           
  Misses              563      563           
  Partials            266      266           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens merged commit 241d0cc into stable/2.7.x Sep 17, 2024
28 checks passed
@sergei-maertens sergei-maertens deleted the backport/4653-tinymce-toolbar-options branch September 17, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TinyMCE missing drop down for headers, paragraph.
2 participants