Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4656] Make parent's serializer context available to the children (FileSerializer) #4683

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Sep 18, 2024

Closes #4656

Changes

  • Added regression test for the editgrid (didn't make context available to the children)
  • Made parent's serializer context available to children (EditGrid)
  • The other nested layout components work with files as expected (fieldset and columns)

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@vaszig vaszig added the needs-backport Fix must be backported to stable release branch label Sep 18, 2024
@vaszig vaszig marked this pull request as draft September 18, 2024 09:39
@vaszig vaszig marked this pull request as ready for review September 18, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport Fix must be backported to stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uploads in repeating groups cause 500 on submit
1 participant