Issue open-horizon#4108 - Feature Request: Fail on agent-install.sh f… #4110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlarson04
reviewed
Jul 18, 2024
agent-install/agent-install.sh
Outdated
| if $KUBECTL get storageclass ${storage_class} >/dev/null 2>&1; then | ||
| log_verbose "storage class $storage_class exists in the edge cluster" | ||
| else | ||
| log_fatal 2 "$storage_class does not exist in the edge cluster" |
There was a problem hiding this comment.
Can you check this log_fatal message to
log_fatal 2 "storage class $storage_class does not exist in the edge cluster"
Currently it fails with
2024-07-18 14:26:10 KUBECTL is set to oc
2024-07-18 14:26:10 EDGE_CLUSTER_STORAGE_CLASS: fred (from environment variable)
2024-07-18 14:26:10 ERROR: fred does not exist in the edge cluster
I guess it is a little obvious that it is checking for the storage class but this would make it very clear
…or k8s agent if storage class is invalid Signed-off-by: Le Zhang <zhangl@us.ibm.com>
LiilyZhang
force-pushed
the
zhangl/Issue4108
branch
from
e3a2673
to
2de617d
Compare
dlarson04
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…or k8s agent if storage class is invalid
Pull Request Template
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Additional Context (Please include any Screenshots/gifs if relevant)
...
Checklist: