Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

array of ports in zone model #1029

Closed
icupeiro opened this issue May 23, 2019 · 8 comments · Fixed by #1156
Closed

array of ports in zone model #1029

icupeiro opened this issue May 23, 2019 · 8 comments · Fixed by #1156
Assignees
Milestone

Comments

@icupeiro
Copy link
Member

Current zone implementation has two air ports intentionally, one for the inlet air and one for the outlet air
The problem comes when the direction of the stream is unknown. It can happen, for instance, that in the same port there are inlet and outlet streams, and in this case there is a possibility that the air streams do not exchange mass/energy with the zone air volume.

A proposed solution is to substitute these two ports by an array of ports, but this change would be non-backwards compatible. To be released in the next major version.

@Mathadon
Copy link
Member

This should be solved together with #1066 .

@Mathadon
Copy link
Member

Proposal is to add a vector port and to keep port_a and port_b for backwards compatibility reasons. We can add a warning using cardinality() to push users towards the new ports vector.

@icupeiro
Copy link
Member Author

is it safe to use cardinality? I thought it was planned to be removed in further modelica releases
Other option could be to use a conditional port, by default in function of the IDEAS version. Is that an implementable solution?

@Mathadon
Copy link
Member

It's been like that for a long time.. I'm not sure whether it will actually happen.

Conditional doesn't really help much here, it's still not reverse compatible if you put default to disabled.

@Mathadon
Copy link
Member

Mathadon commented Mar 30, 2020

@damienpicard @icupeiro should we remove the icon illustration of port_a and port_b to discourage using the ports? The icon is also quite busy now so that would be an added benefit.

@Mathadon
Copy link
Member

Mathadon commented Mar 30, 2020

@cprotopa fyi for BoFy, the zone interface is changing but it will stay backwards compatible for now

@Mathadon Mathadon self-assigned this Mar 30, 2020
@Mathadon Mathadon modified the milestones: Release 3, Release 2.2 Mar 30, 2020
Mathadon added a commit that referenced this issue Mar 30, 2020
removed icons of port_a and port_b
Mathadon added a commit that referenced this issue Mar 30, 2020
@icupeiro
Copy link
Member Author

icupeiro commented Mar 30, 2020

@Mathadon Agreed, not possible to add the annotation if the port is used right?

@Mathadon
Copy link
Member

Mathadon commented Mar 30, 2020 via email

Mathadon added a commit that referenced this issue Jul 21, 2020
added port vector to zones
Mathadon added a commit that referenced this issue Jul 21, 2020
damienpicard pushed a commit that referenced this issue Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants