1066 interzonal #1164
Closed
1066 interzonal #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added interzonalAirflowType and added two ports in propsubs
…ngularZoneTemplateInterface.mo for #1066
bugfixes for #1066
when combined with series connections of propsBusses
introduced n50_int in order to differentiate n50_int within SIM
Noticed that no default was provided anymore for n50 zone, in the current implementation the easiest way to solve this is to provide the default as the start value. This works but will promt a warning during translation pointing out to the user that not really a value was provided.
restored n50 values originally input in simulations. Added variation with 1_port and adapted ventilation system as additional model
n50_int to work around warning "fixed=false also has binding" that failed the unit test
Revert changes in PartialTwinHouse that made non-pressure driven simulations crash due to pressure rise. redeclared correct ventilation system on top level for Exp1_1Port
SimInfomanager calculates one Cs for the building surfaces (regardless of effective height). Default is suburban and hroof equal to href (no wind velocity profile correction) Same calculation also available in 'OutsideAir' where it expects the height of the boundary as input. Not used in implementation for now as heights of zones and surfaces not known yet. Once this is done, the Cs in sim can be eliminated.
Co-authored-by: Filip Jorissen <filip.jorissen@kuleuven.be>
Co-authored-by: Filip Jorissen <filip.jorissen@kuleuven.be>
Co-authored-by: Filip Jorissen <filip.jorissen@kuleuven.be>
Co-authored-by: Filip Jorissen <filip.jorissen@kuleuven.be>
Co-authored-by: Filip Jorissen <filip.jorissen@kuleuven.be>
1066 interzonal v3
When the user asigns a q50 value to all surfaces, the zone recognises this and the n50 is calculated. Some annotation changes in dialog
Implementation didn't take into account nWin parameter for window component
…oneAirModels/WellMixedAir.mo
|
superseded by #1215 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work in progress for #1066, @kldjonge fyi