[Fix] Fix saconv #1147
[Fix] Fix saconv #1147
Conversation
|
|
|
CI failed on PyTorch 1.6. |
mmcv/ops/saconv.py
Outdated
| @@ -120,7 +124,8 @@ def forward(self, x): | |||
| if TORCH_VERSION < '1.5.0' or TORCH_VERSION == 'parrots': | |||
| out_l = super().conv2d_forward(x, weight) | |||
| else: | |||
| out_l = super()._conv_forward(x, weight) | |||
| # bias is a required argument of _conv_forward in torch 1.9.0 | |||
There was a problem hiding this comment.
Bias is also required by torch1.8. You can check the version of torch to handle this
Codecov Report
@@ Coverage Diff @@
## master #1147 +/- ##
==========================================
+ Coverage 67.85% 67.97% +0.11%
==========================================
Files 159 159
Lines 10378 10426 +48
Branches 1885 1897 +12
==========================================
+ Hits 7042 7087 +45
- Misses 2967 2970 +3
Partials 369 369
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
suggest to also use loosversion for version check. |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Fix SAConv forward, be compatible with torch1.9.0
Modification
Add zero_bias in the arguments of _conv_forward