Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix CI of publishing package #1220

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

zhouzaida
Copy link
Collaborator

@zhouzaida zhouzaida commented Jul 27, 2021

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Related Issue: #1219
Related Action: https://github.com/open-mmlab/mmcv/runs/3150536246?check_suite_focus=true#step:4:17

Fix CI of publishing package

Modification

  • .github/workflows/build.yml
  • .github/workflows/publish-to-pypi.yml

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@zhouzaida zhouzaida requested a review from ZwwWayne July 27, 2021 14:44
@zhouzaida zhouzaida mentioned this pull request Jul 27, 2021
18 tasks
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #1220 (0d91f3c) into master (88d8c9e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1220   +/-   ##
=======================================
  Coverage   68.27%   68.27%           
=======================================
  Files         160      160           
  Lines       10599    10599           
  Branches     1937     1937           
=======================================
  Hits         7236     7236           
  Misses       2979     2979           
  Partials      384      384           
Flag Coverage Δ
unittests 68.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88d8c9e...0d91f3c. Read the comment docs.

@ZwwWayne
Copy link
Collaborator

Do we also need to update our requirements?

@zhouzaida
Copy link
Collaborator Author

zhouzaida commented Jul 27, 2021

Do we also need to update our requirements?

In fact, the requirement has been updated before but it seemly didn't work because the error is raised before running python setup.py develop. Maybe this line can be removed.

setuptools>=52

@ZwwWayne ZwwWayne merged commit 571e3e5 into open-mmlab:master Jul 28, 2021
@zhouzaida zhouzaida deleted the fix-deploy-ci branch August 3, 2021 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants