Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refine] refine contributing.md #1941

Merged
merged 38 commits into from
Nov 18, 2022
Merged

[Refine] refine contributing.md #1941

merged 38 commits into from
Nov 18, 2022

Conversation

HAOCHENYE
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Refine contributing.md

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@HAOCHENYE HAOCHENYE changed the title Haochenye/refine contributing.md [Refine] refine contributing.md May 8, 2022
CONTRIBUTING.md Outdated Show resolved Hide resolved
@zhouzaida
Copy link
Collaborator

CONTRIBUTING.md Outdated Show resolved Hide resolved
@zhouzaida
Copy link
Collaborator

CONTRIBUTING-zh-CN.md Outdated Show resolved Hide resolved
CONTRIBUTING-zh-CN.md Outdated Show resolved Hide resolved
CONTRIBUTING-zh-CN.md Outdated Show resolved Hide resolved
CONTRIBUTING-zh-CN.md Outdated Show resolved Hide resolved
CONTRIBUTING-zh-CN.md Outdated Show resolved Hide resolved
CONTRIBUTING-zh-CN.md Outdated Show resolved Hide resolved
CONTRIBUTING_zh-CN.md Outdated Show resolved Hide resolved
CONTRIBUTING_zh-CN.md Outdated Show resolved Hide resolved
CONTRIBUTING_zh-CN.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@zhouzaida zhouzaida merged commit abb600a into open-mmlab:master Nov 18, 2022
zhouzaida pushed a commit to zhouzaida/mmcv that referenced this pull request Nov 22, 2022
* refaictor CONTRIBUDING.MD

* refaictor CONTRIBUDING.MD

* fix source rvm shell command

* fix lint

* add chinese contributing.md

* fix error render

* fix error render

* refine description

* refine description

* minor refine

* install ffmpeg before ut

* Minor retfine

* Minor refine

* refine chinese contributing.md

* Refine

* Fix as comment

* Fix as comment

* restore pr.md

* minor refine

* minor refine

* update chinese CONTRIBUTING.md in root dir

* adjust imgae size

* update en CONTRIBUTING.md

* update en CONTRIBUTING.md

* update contributing.md in docs

* restore change of index.rst

* Fix as comment

* minor refine

* remove content in PR.md

* minor refine

* minor refine

* minor refine

* Fix as comment

* rename

* minor refine
zhouzaida pushed a commit that referenced this pull request Nov 23, 2022
* refaictor CONTRIBUDING.MD

* refaictor CONTRIBUDING.MD

* fix source rvm shell command

* fix lint

* add chinese contributing.md

* fix error render

* fix error render

* refine description

* refine description

* minor refine

* install ffmpeg before ut

* Minor retfine

* Minor refine

* refine chinese contributing.md

* Refine

* Fix as comment

* Fix as comment

* restore pr.md

* minor refine

* minor refine

* update chinese CONTRIBUTING.md in root dir

* adjust imgae size

* update en CONTRIBUTING.md

* update en CONTRIBUTING.md

* update contributing.md in docs

* restore change of index.rst

* Fix as comment

* minor refine

* remove content in PR.md

* minor refine

* minor refine

* minor refine

* Fix as comment

* rename

* minor refine
ckirchhoff2021 pushed a commit to ckirchhoff2021/mmcv that referenced this pull request Dec 21, 2022
* refaictor CONTRIBUDING.MD

* refaictor CONTRIBUDING.MD

* fix source rvm shell command

* fix lint

* add chinese contributing.md

* fix error render

* fix error render

* refine description

* refine description

* minor refine

* install ffmpeg before ut

* Minor retfine

* Minor refine

* refine chinese contributing.md

* Refine

* Fix as comment

* Fix as comment

* restore pr.md

* minor refine

* minor refine

* update chinese CONTRIBUTING.md in root dir

* adjust imgae size

* update en CONTRIBUTING.md

* update en CONTRIBUTING.md

* update contributing.md in docs

* restore change of index.rst

* Fix as comment

* minor refine

* remove content in PR.md

* minor refine

* minor refine

* minor refine

* Fix as comment

* rename

* minor refine
lizhihao6 added a commit to lizhihao6/mmcv that referenced this pull request Jan 16, 2023
tyomj pushed a commit to tyomj/mmcv that referenced this pull request May 8, 2023
* refaictor CONTRIBUDING.MD

* refaictor CONTRIBUDING.MD

* fix source rvm shell command

* fix lint

* add chinese contributing.md

* fix error render

* fix error render

* refine description

* refine description

* minor refine

* install ffmpeg before ut

* Minor retfine

* Minor refine

* refine chinese contributing.md

* Refine

* Fix as comment

* Fix as comment

* restore pr.md

* minor refine

* minor refine

* update chinese CONTRIBUTING.md in root dir

* adjust imgae size

* update en CONTRIBUTING.md

* update en CONTRIBUTING.md

* update contributing.md in docs

* restore change of index.rst

* Fix as comment

* minor refine

* remove content in PR.md

* minor refine

* minor refine

* minor refine

* Fix as comment

* rename

* minor refine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants