Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Support SiLU with torch < 1.7.0 #2278

Merged
merged 6 commits into from
Sep 29, 2022
Merged

[Enhancement] Support SiLU with torch < 1.7.0 #2278

merged 6 commits into from
Sep 29, 2022

Conversation

okotaku
Copy link
Contributor

@okotaku okotaku commented Sep 22, 2022 •
edited
Loading

Motivation

Support SiLU with torch < 1.7.0.
Related discussion: open-mmlab/mmdetection#8778 (comment)
Related code: https://github.com/open-mmlab/mmyolo/blob/84f115c4e57856ab63417fb9b781db88fe10ccf1/mmyolo/models/layers/yolo_bricks.py#L14-L27

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@okotaku okotaku changed the title [Enhancement] upport SiLU torch<1.7.0 [Enhancement] upport SiLU with torch < 1.7.0 Sep 22, 2022
@okotaku okotaku changed the title [Enhancement] upport SiLU with torch < 1.7.0 [Enhancement] Support SiLU with torch < 1.7.0 Sep 22, 2022
@okotaku okotaku mentioned this pull request Sep 22, 2022
Open
@okotaku @zhouzaida
Update tests/test_cnn/test_silu.py
93fafc8 
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
@zhouzaida zhouzaida merged commit afff388 into open-mmlab:master Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhouzaida zhouzaida zhouzaida approved these changes

Assignees

@zhouzaida zhouzaida

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@okotaku @zhouzaida