Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the block size to 1024 during compilation. #2460

Merged
merged 5 commits into from
Dec 28, 2022
Merged

Change the block size to 1024 during compilation. #2460

merged 5 commits into from
Dec 28, 2022

Conversation

xiabo123
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

The default block size of rocm is 256.The designed kenel has a block size of 512.Change the block size to 1024 during compilation.

Modification

The default block size of rocm is 256.The designed kenel has a block size of 512.Change the block size to 1024 during compilation.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

…size of 512.Change the block size to 1024 during compilation.
@CLAassistant
Copy link

CLAassistant commented Nov 28, 2022

CLA assistant check
All committers have signed the CLA.

…size of 512.Change the block size to 1024 during compilation.
…size of 512.Change the block size to 1024 during compilation.
…size of 512.Change the block size to 1024 during compilation.
Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouzaida zhouzaida merged commit 30d975a into open-mmlab:master Dec 28, 2022
defei-coder pushed a commit to defei-coder/mmcv that referenced this pull request Jan 30, 2023
* The default block size of rocm is 256.The designed kenel has a block size of 512.Change the block size to 1024 during compilation.

* The default block size of rocm is 256.The designed kenel has a block size of 512.Change the block size to 1024 during compilation.

* The default block size of rocm is 256.The designed kenel has a block size of 512.Change the block size to 1024 during compilation.

* The default block size of rocm is 256.The designed kenel has a block size of 512.Change the block size to 1024 during compilation.
@OpenMMLab-Assistant005
Copy link

Dear xiabo123,
First of all, we want to express our gratitude for your significant PR in the MMCV project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.
If you are Chinese or have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. We look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG
Thank you again for your contribution❤
Best regards! @xiabo123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants