Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Pick npu ops from master to 2.x #2501

Merged
merged 7 commits into from
Jan 13, 2023

Conversation

ckirchhoff2021
Copy link
Collaborator

The PR is for merging npu ops from master to 2.x. I've constructed some unit-tests to test the op on my local machine, and the result looks good.

@zhouzaida zhouzaida added the NPU Ascend label Jan 4, 2023
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Base: 66.34% // Head: 66.30% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (98b291e) compared to base (78fdf17).
Patch coverage: 40.54% of modified lines in pull request are covered.

❗ Current head 98b291e differs from pull request most recent head ca99d17. Consider uploading reports for the commit ca99d17 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #2501      +/-   ##
==========================================
- Coverage   66.34%   66.30%   -0.05%     
==========================================
  Files         120      121       +1     
  Lines        7746     7926     +180     
  Branches     1074     1084      +10     
==========================================
+ Hits         5139     5255     +116     
- Misses       2438     2498      +60     
- Partials      169      173       +4     
Flag Coverage Δ
unittests 66.30% <40.54%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/ops/focal_loss.py 25.00% <0.00%> (+1.36%) ⬆️
mmcv/ops/masked_conv.py 36.84% <0.00%> (-5.72%) ⬇️
mmcv/ops/modulated_deform_conv.py 65.18% <11.42%> (-15.14%) ⬇️
mmcv/ops/deform_conv.py 66.66% <20.00%> (-4.98%) ⬇️
mmcv/ops/bezier_align.py 74.46% <74.46%> (ø)
mmcv/ops/__init__.py 100.00% <100.00%> (ø)
mmcv/utils/__init__.py 100.00% <100.00%> (ø)
mmcv/utils/device_type.py 100.00% <100.00%> (ø)
mmcv/transforms/base.py 100.00% <0.00%> (ø)
mmcv/ops/active_rotated_filter.py 100.00% <0.00%> (ø)
... and 34 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouzaida zhouzaida changed the title [Feature]: merge npu ops from master to 2.x [Feature] Pick npu ops from master to 2.x Jan 13, 2023
@zhouzaida zhouzaida merged commit 34bdf44 into open-mmlab:2.x Jan 13, 2023
tyomj pushed a commit to tyomj/mmcv that referenced this pull request May 8, 2023
* merge npu ops from master to 2.x

* BugFix: fix merge bugs

* {[Feature]: add psamask, roipool to 2.x, and fix the SigmoidFocalLoss assert condition

* merge conflicts in ops.md

* [fix]: fix merge bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPU Ascend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants