Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing contiguous calls for nms_rotated #2547

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Add missing contiguous calls for nms_rotated #2547

merged 1 commit into from
Feb 1, 2023

Conversation

allanzelener
Copy link

Motivation

Addresses issue #2542

Modification

For nms_rotated_cuda only adds contiguous call to dets_sorted which is accessed directly. For nms_rotated_cpu the implementation now matches what's in the detectron2 repo.

BC-breaking (Optional)

No, bug fix only.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@allanzelener
Add missing contiguous calls for nms_rotated
cd4280a 
Addresses issue open-mmlab#2542

For nms_rotated_cuda only adds contiguous call to dets_sorted which is accessed directly.
For nms_rotated_cpu the implementation now matches what's in the detectron2 repo.
@CLAassistant
Copy link

CLAassistant commented Jan 12, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@zhouzaida zhouzaida linked an issue Feb 1, 2023 that may be closed by this pull request
Incorrect results for CPU version of nms_rotated on non-contiguous inputs #2542
Closed
@zhouzaida zhouzaida merged commit 497c2df into open-mmlab:master Feb 1, 2023
@allanzelener allanzelener deleted the patch-1 branch February 3, 2023 19:52
@OpenMMLab-Assistant001
Copy link

Hi @allanzelener ！First of all, we want to express our gratitude for your significant PR in the MMCV project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us ：https://discord.gg/UjgXkPWNqA

If you have WeChat account，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends：）
Thank you again for your contribution！❤

CokeDong pushed a commit to CokeDong/mmcv that referenced this pull request Apr 24, 2023
@allanzelener @CokeDong
[Fix] Add missing contiguous calls for nms_rotated (open-mmlab#2547)
48dbae4 
Addresses issue open-mmlab#2542

For nms_rotated_cuda only adds contiguous call to dets_sorted which is accessed directly.
For nms_rotated_cpu the implementation now matches what's in the detectron2 repo.
fwenguang pushed a commit to fwenguang/mmcv that referenced this pull request Dec 19, 2023
@allanzelener @ClowDragon
[Fix] Add missing contiguous calls for nms_rotated (open-mmlab#2547)
ca3eda1 
Addresses issue open-mmlab#2542

For nms_rotated_cuda only adds contiguous call to dets_sorted which is accessed directly.
For nms_rotated_cpu the implementation now matches what's in the detectron2 repo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhouzaida zhouzaida zhouzaida approved these changes

Assignees

@zhouzaida zhouzaida

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect results for CPU version of nms_rotated on non-contiguous inputs
4 participants
@allanzelener @CLAassistant @OpenMMLab-Assistant001 @zhouzaida