Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhance] The argument scale of fused_bias_leakyrelu should be greater than 0 #2623

Merged
merged 4 commits into from
Feb 27, 2023
Merged

[Enhance] The argument scale of fused_bias_leakyrelu should be greater than 0 #2623

merged 4 commits into from
Feb 27, 2023

Conversation

jayggh
Copy link

@jayggh jayggh commented Feb 27, 2023 •
edited
Loading

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Add verification for scale, when scale less than 0

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@zhouzaida zhouzaida linked an issue Feb 27, 2023 that may be closed by this pull request
[Bug] when scale is negative , the gradient of fusedbiasleakyrelu is incorrect #2620
Closed
2 tasks
jayggh and others added 3 commits February 27, 2023 15:03
@jayggh @zhouzaida
Update mmcv/ops/fused_bias_leakyrelu.py
8b93e9f 
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
@jayggh
Update fused_bias_leakyrelu.py
4639456
@jayggh
Update fused_bias_leakyrelu.py
64f550d
@zhouzaida zhouzaida changed the title Add verification for scale, when scale less than 0 [Enhance] The argument scale of fused_bias_leakyrelu should be greater than 0 Feb 27, 2023
@zhouzaida zhouzaida merged commit ec63932 into open-mmlab:master Feb 27, 2023
CokeDong pushed a commit to CokeDong/mmcv that referenced this pull request Apr 24, 2023
@jayggh @zhouzaida @CokeDong
[Enhance] The argument scale of fused_bias_leakyrelu should be greate…
bef4382 
…r than 0 (open-mmlab#2623)

* Add verification for scale, when scale less than 0

* Update mmcv/ops/fused_bias_leakyrelu.py

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>

* Update fused_bias_leakyrelu.py

* Update fused_bias_leakyrelu.py

---------

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhouzaida zhouzaida zhouzaida approved these changes

Assignees

@zhouzaida zhouzaida

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] when scale is negative , the gradient of fusedbiasleakyrelu is incorrect
2 participants
@jayggh @zhouzaida