Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Repalce the implementation of roiaware_pool3d with mlu-ops. #2699

Merged
merged 2 commits into from
Apr 3, 2023
Merged

[Feature] Repalce the implementation of roiaware_pool3d with mlu-ops. #2699

merged 2 commits into from
Apr 3, 2023

Conversation

ZhangLearning
Copy link
Contributor

@ZhangLearning ZhangLearning commented Mar 24, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

The motivation of the PR is to support running RoiawarePool3d with Cambricon MLU backend.

It includes three parts:

1. Delete roiaware_pool3d_mlu_kernel.mlu src code as MLU kernel.
2. Modify roiaware_pool3d_mlu_kernel.cpp to support launching kernel in PyTorch.

Modification

  • MLU src code
    Delete MLU src code of RoiawarePool3d in directory mmcv/ops/csrc/common/mlu/roiaware_pool3d_mlu_kernel.mlu.
  • PyTorch adaptation
    Modify RoiawarePool3d for PyTorch in mmcv/ops/csrc/pytorch/mlu/roiaware_pool3d_mlu_kernel.cpp.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@zhouzaida zhouzaida added the MLU label Mar 28, 2023
@zhouzaida zhouzaida merged commit bc727f7 into open-mmlab:master Apr 3, 2023
momo609 pushed a commit to momo609/mmcv that referenced this pull request Apr 4, 2023
…ops. (open-mmlab#2699)

* [Feature] Repalce the implementation of roiaware_pool3d with mlu-ops.

* [Feature] Repalce the implementation of roiaware_pool3d with mlu-ops.
CokeDong pushed a commit to CokeDong/mmcv that referenced this pull request Apr 24, 2023
…ops. (open-mmlab#2699)

* [Feature] Repalce the implementation of roiaware_pool3d with mlu-ops.

* [Feature] Repalce the implementation of roiaware_pool3d with mlu-ops.
defei-coder pushed a commit to defei-coder/mmcv that referenced this pull request May 19, 2023
…ops. (open-mmlab#2699)

* [Feature] Repalce the implementation of roiaware_pool3d with mlu-ops.

* [Feature] Repalce the implementation of roiaware_pool3d with mlu-ops.
@defei-coder defei-coder mentioned this pull request May 19, 2023
7 tasks
fwenguang pushed a commit to fwenguang/mmcv that referenced this pull request Dec 19, 2023
…ops. (open-mmlab#2699)

* [Feature] Repalce the implementation of roiaware_pool3d with mlu-ops.

* [Feature] Repalce the implementation of roiaware_pool3d with mlu-ops.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants