Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix deform_conv ops on Ascend NPU #2805

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

Ginray
Copy link
Contributor

@Ginray Ginray commented May 22, 2023

Motivation

Fix deform_conv ops on Ascend NPU.

Modification

Fix the problem that the input parameter of padding is incorrect.

BC-breaking (Optional)

Not involving.

Use cases (Optional)

We have verified the correctness on related models, such as solov2_r101_dcn_fpn_3x_coco.py.

Checklist

Before PR:

  • [ √] I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • [√ ] Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • [√ ] Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • [√ ] New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • [√ ] The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • [ √] If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • [√ ] CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented May 22, 2023

CLA assistant check
All committers have signed the CLA.

@momo609
Copy link
Collaborator

momo609 commented Jun 15, 2023

/lgtm

@zhouzaida zhouzaida merged commit f07ed6b into open-mmlab:1.x Jun 15, 2023
Danielmic pushed a commit to Danielmic/mmcv that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants