Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Keep the shape value of ascend iou op's parameter 2 smaller than parameter 1 #2820

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

dflhw
Copy link
Contributor

@dflhw dflhw commented Jun 5, 2023

Motivation

It is found that parameter 2(ground truth) of the iou op does not support oversized shape([~32000+, 4]), so add a check.

Modification

If the value of gtboxesFP32‘s shape is greater than bboxesFP32, swap them.

@dflhw dflhw changed the title [Refactor] Keep the shape value of iou op's parameter 2 smaller than parameter 1 [Fix] Keep the shape value of iou op's parameter 2 smaller than parameter 1 Jun 5, 2023
@momo609
Copy link
Collaborator

momo609 commented Jun 7, 2023

/lookgood

@dflhw dflhw changed the title [Fix] Keep the shape value of iou op's parameter 2 smaller than parameter 1 [Fix] Keep the shape value of ascend iou op's parameter 2 smaller than parameter 1 Jun 8, 2023
@ckirchhoff2021 ckirchhoff2021 self-requested a review June 8, 2023 13:14
Copy link
Collaborator

@ckirchhoff2021 ckirchhoff2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@zhouzaida zhouzaida merged commit 16d52da into open-mmlab:1.x Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants