Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add the support of BallQuery op for Ascend device #2963

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

Ginray
Copy link
Contributor

@Ginray Ginray commented Oct 12, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add the support of BallQuery op for Ascend device.

Modification

Add operator implementation files and test cases.

BC-breaking (Optional)

Not involving.

Use cases (Optional)

Already adapted to original test cases.

Checklist

Before PR:

  • [√] I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • [√] Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • [√] Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • [√] New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • [√] The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • [√] If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • [√] CLA has been signed and all committers have signed the CLA in this PR.

@Ginray Ginray force-pushed the adapt_ball_query_op branch 3 times, most recently from fe53366 to 178485f Compare October 12, 2023 13:18
@zhouzaida zhouzaida merged commit c0774b5 into open-mmlab:main Oct 13, 2023
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants