-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: add custom op roialign for onnxruntime #724
Conversation
Codecov Report
@@ Coverage Diff @@
## master #724 +/- ##
==========================================
- Coverage 64.86% 64.77% -0.09%
==========================================
Files 136 136
Lines 7991 7999 +8
Branches 1411 1412 +1
==========================================
- Hits 5183 5181 -2
- Misses 2539 2549 +10
Partials 269 269
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Please sign CLA and fix lint at first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
add onnxruntime custom op MMCVRoIAlign,so we can use mmcvroialign in onnxruntime;
use mmcv domain as custom op's domain, this is required for torch to export custom op;
An ONNX opset consists of a domain name and a version number. If we are using existing ONNX operators (from the default ONNX domain), we do not need to add the domain name prefix. In mmcv, we want to use an op from mmcv custom opset. Therefore, we need to add the domain name as a prefix in the following format: "<domain_name>::<onnx_op>"