Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: add custom op roialign for onnxruntime #724

Merged
merged 21 commits into from
Dec 29, 2020
Merged

[Feature]: add custom op roialign for onnxruntime #724

merged 21 commits into from
Dec 29, 2020

Conversation

tangyanf
Copy link
Contributor

add onnxruntime custom op MMCVRoIAlign,so we can use mmcvroialign in onnxruntime;
use mmcv domain as custom op's domain, this is required for torch to export custom op;
An ONNX opset consists of a domain name and a version number. If we are using existing ONNX operators (from the default ONNX domain), we do not need to add the domain name prefix. In mmcv, we want to use an op from mmcv custom opset. Therefore, we need to add the domain name as a prefix in the following format: "<domain_name>::<onnx_op>"

@CLAassistant
Copy link

CLAassistant commented Dec 16, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #724 (03781c0) into master (94810f2) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #724      +/-   ##
==========================================
- Coverage   64.86%   64.77%   -0.09%     
==========================================
  Files         136      136              
  Lines        7991     7999       +8     
  Branches     1411     1412       +1     
==========================================
- Hits         5183     5181       -2     
- Misses       2539     2549      +10     
  Partials      269      269              
Flag Coverage Δ
unittests 64.77% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/ops/roi_align.py 54.65% <0.00%> (-7.20%) ⬇️
mmcv/utils/parrots_jit.py 76.47% <0.00%> (-5.35%) ⬇️
mmcv/ops/box_iou_rotated.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94810f2...03781c0. Read the comment docs.

@RunningLeon RunningLeon self-assigned this Dec 17, 2020
@RunningLeon RunningLeon self-requested a review December 17, 2020 12:34
@RunningLeon
Copy link
Collaborator

Please sign CLA and fix lint at first.

@RunningLeon
Copy link
Collaborator

@tangyanf
Since #612 has been merged into master and this PR is based on #612, we could merge with the newest master at first.

@RunningLeon RunningLeon changed the title add ort custom op roialign [Feature]: add custom op roialign for onnxruntime Dec 23, 2020
Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/onnxruntime_op.md Outdated Show resolved Hide resolved
@ZwwWayne ZwwWayne merged commit 741e52d into open-mmlab:master Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants