Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile mmcv with custom op when not using cuda #945

Merged
merged 1 commit into from
Apr 17, 2021
Merged

Compile mmcv with custom op when not using cuda #945

merged 1 commit into from
Apr 17, 2021

Conversation

tangyanf
Copy link
Contributor

When I compile mmcv with custom op on a machine that does not have cuda installed, I will encounter the following error:
image
So I modified the code to get the cuda header file path when compiling Ort custom op in setup.py
image

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #945 (c1ff46c) into master (79f8cbd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #945   +/-   ##
=======================================
  Coverage   65.67%   65.67%           
=======================================
  Files         149      149           
  Lines        9451     9451           
  Branches     1720     1720           
=======================================
  Hits         6207     6207           
  Misses       2924     2924           
  Partials      320      320           
Flag Coverage Δ
unittests 65.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79f8cbd...c1ff46c. Read the comment docs.

@hellock hellock requested a review from zhouzaida April 17, 2021 02:14
Copy link
Collaborator

@zhouzaida zhouzaida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hellock hellock merged commit 5504b5f into open-mmlab:master Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants