Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] fix raise error bug in registering multiple names #949

Merged
merged 5 commits into from
Apr 25, 2021

Conversation

nbei
Copy link
Contributor

@nbei nbei commented Apr 15, 2021

No description provided.

@nbei nbei requested a review from ZwwWayne April 15, 2021 09:31
@zhouzaida
Copy link
Collaborator

ping @xvjiarui @ZwwWayne

mmcv/utils/registry.py Outdated Show resolved Hide resolved
mmcv/utils/registry.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #949 (bdcf291) into master (54ece10) will decrease coverage by 0.37%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #949      +/-   ##
==========================================
- Coverage   65.64%   65.27%   -0.38%     
==========================================
  Files         149      151       +2     
  Lines        9455     9618     +163     
  Branches     1722     1741      +19     
==========================================
+ Hits         6207     6278      +71     
- Misses       2928     3017      +89     
- Partials      320      323       +3     
Flag Coverage Δ
unittests 65.27% <100.00%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/utils/registry.py 98.31% <100.00%> (-0.02%) ⬇️
mmcv/runner/base_module.py 78.78% <0.00%> (-0.63%) ⬇️
mmcv/ops/__init__.py 100.00% <0.00%> (ø)
mmcv/ops/box_iou_rotated.py 100.00% <0.00%> (ø)
mmcv/cnn/bricks/transformer.py 0.00% <0.00%> (ø)
mmcv/ops/fused_bias_leakyrelu.py 30.90% <0.00%> (ø)
mmcv/ops/multi_scale_deform_attn.py 76.66% <0.00%> (ø)
mmcv/ops/roi_align_rotated.py 75.38% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54ece10...bdcf291. Read the comment docs.

@hellock
Copy link
Member

hellock commented Apr 17, 2021

What is the intention of this PR?

@nbei
Copy link
Contributor Author

nbei commented Apr 17, 2021

What is the intention of this PR?

Since we have supported a sequence of names, the logic for raising error should be modified.

@ZwwWayne
Copy link
Collaborator

Unit test failed.

@ZwwWayne ZwwWayne self-assigned this Apr 24, 2021
@ZwwWayne
Copy link
Collaborator

ping @nbei

@ZwwWayne ZwwWayne merged commit 0be0410 into open-mmlab:master Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants