Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] replace mmcv's function and modules imported with mmengine's and sync the latest mmengine #1765

Merged
merged 3 commits into from
Aug 26, 2022

Conversation

VVsssssk
Copy link
Collaborator

@VVsssssk VVsssssk commented Aug 24, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Replace mmcv func.

Modification

  1. use mmengine's Config load_state_dict, FileClient, dump, load_checkpoint and etc.
    changes due to Remove runner, parallel, engine and device mmcv#2216, Remove many functions in utils mmcv#2217, Migrate utils from mmcv mmengine#447
  2. sync the latest mmengine

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@VVsssssk VVsssssk changed the base branch from master to dev-1.x August 24, 2022 13:26
@ZCMax ZCMax changed the title [Fix]Replace mmcv func [Fix] replace mmcv's function and modules imported with mmengine's Aug 25, 2022
@ZCMax ZCMax changed the title [Fix] replace mmcv's function and modules imported with mmengine's [Fix] replace mmcv's function and modules imported with mmengine's and sync the latest mmengine Aug 25, 2022
@ZwwWayne ZwwWayne merged commit 4f88f1a into open-mmlab:dev-1.x Aug 26, 2022
ZCMax pushed a commit to ZCMax/mmdetection3d that referenced this pull request Aug 26, 2022
…d sync the latest mmengine (open-mmlab#1765)

* replace mmcv to mmengine

* fix

* fix comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants