[Enhancement] Silence error when ManagerMixin built instance with d…

…uplicate name. (#990)

* [Fix]Silence error when ManagerMixin built duplicate name instance

* [Fix]Silence error when ManagerMixin built duplicate name instance

* Update mmengine/utils/manager.py

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>

---------

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>

mmengine/utils/manager.py

@@ -1,6 +1,7 @@
 # Copyright (c) OpenMMLab. All rights reserved.
 import inspect
 import threading
+import warnings
 from collections import OrderedDict
 from typing import Type, TypeVar
 
@@ -108,10 +109,11 @@ def get_instance(cls: Type[T], name: str, **kwargs) -> T:
         if name not in instance_dict:
             instance = cls(name=name, **kwargs)  # type: ignore
             instance_dict[name] = instance  # type: ignore
-        else:
-            assert not kwargs, (
-                f'{cls} instance named of {name} has been created, the method '
-                '`get_instance` should not access any other arguments')
+        elif kwargs:
+            warnings.warn(
+                f'{cls} instance named of {name} has been created, '
+                'the method `get_instance` should not accept any other '
+                'arguments')
         # Get latest instantiated instance or root instance.
         _release_lock()
         return instance_dict[name]

tests/test_utils/test_manager.py

@@ -72,5 +72,5 @@ def test_get_instance(self):
             SubClassA.get_instance(name=1)
         # `get_instance` should not accept other arguments if corresponding
         # instance has been created.
-        with pytest.raises(AssertionError):
+        with pytest.warns(UserWarning):
             SubClassA.get_instance('name2', a=1, b=2)