Skip to content

Commit

Permalink
Fix as comment
Browse files Browse the repository at this point in the history
  • Loading branch information
HAOCHENYE committed Mar 10, 2023
1 parent 4f55cb5 commit b824621
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions mmengine/logging/logger.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from mmengine.utils.manager import _accquire_lock, _release_lock


class UniqueWarningFilter(logging.Filter):
class FilterDuplicateWarning(logging.Filter):
"""Filter the repeated warning message.
Args:
Expand All @@ -34,9 +34,8 @@ def filter(self, record: LogRecord) -> bool:
if record.levelno != logging.WARNING:
return True

msg = record.msg
if msg not in self.seen:
self.seen.add(msg)
if record.msg not in self.seen:
self.seen.add(record.msg)
return True
return False

Expand Down Expand Up @@ -194,7 +193,7 @@ def __init__(self,
# Only rank0 `StreamHandler` will log messages below error level.
stream_handler.setLevel(log_level) if rank == 0 else \
stream_handler.setLevel(logging.ERROR)
stream_handler.addFilter(UniqueWarningFilter(logger_name))
stream_handler.addFilter(FilterDuplicateWarning(logger_name))
self.handlers.append(stream_handler)

if log_file is not None:
Expand Down Expand Up @@ -222,7 +221,7 @@ def __init__(self,
file_handler.setFormatter(
MMFormatter(color=False, datefmt='%Y/%m/%d %H:%M:%S'))
file_handler.setLevel(log_level)
file_handler.addFilter(UniqueWarningFilter(logger_name))
file_handler.addFilter(FilterDuplicateWarning(logger_name))
self.handlers.append(file_handler)

@classmethod
Expand Down

0 comments on commit b824621

Please sign in to comment.