fix the bug when the params in shared modules do not require grad

open-mmlab · Feb 3, 2023 · bad1c33 · bad1c33
1 parent 6dc1d70
commit bad1c33
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/mmengine/optim/optimizer/default_constructor.py b/mmengine/optim/optimizer/default_constructor.py
@@ -204,13 +204,14 @@ def add_params(self,
 
         for name, param in module.named_parameters(recurse=False):
             param_group = {'params': [param]}
-            if not param.requires_grad:
-                params.append(param_group)
-                continue
             if bypass_duplicate and self._is_in(param_group, params):
                 warnings.warn(f'{prefix} is duplicate. It is skipped since '
                               f'bypass_duplicate={bypass_duplicate}')
                 continue
+            if not param.requires_grad:
+                params.append(param_group)
+                continue
+
             # if the parameter match one of the custom keys, ignore other rules
             is_custom = False
             for key in sorted_keys: