-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Support BoolTensor and LongTensor on Ascend NPU #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ginray
force-pushed
the
dev-for-tensor-fixed
branch
2 times, most recently
from
March 24, 2023 09:20
fbe04b7
to
67d513b
Compare
HAOCHENYE
reviewed
Mar 31, 2023
Ginray
force-pushed
the
dev-for-tensor-fixed
branch
from
April 3, 2023 07:51
67d513b
to
a1a903e
Compare
HAOCHENYE
previously approved these changes
Apr 6, 2023
zhouzaida
reviewed
Apr 10, 2023
zhouzaida
reviewed
Apr 10, 2023
Ginray
force-pushed
the
dev-for-tensor-fixed
branch
from
April 10, 2023 07:23
a1a903e
to
e008040
Compare
Ginray
force-pushed
the
dev-for-tensor-fixed
branch
from
April 10, 2023 07:54
e008040
to
98464dc
Compare
zhouzaida
approved these changes
Apr 10, 2023
zhouzaida
changed the title
[Fix] Support BoolTensor and LongTensor on Ascend NPU.
[Fix] Support BoolTensor and LongTensor on Ascend NPU
Apr 10, 2023
zhouzaida
changed the title
[Fix] Support BoolTensor and LongTensor on Ascend NPU
[Enhancement] Support BoolTensor and LongTensor on Ascend NPU
Apr 10, 2023
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1011 +/- ##
=======================================
Coverage ? 76.42%
=======================================
Files ? 139
Lines ? 11190
Branches ? 2249
=======================================
Hits ? 8552
Misses ? 2276
Partials ? 362
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When we test the ssd model on the NPU, an assert error occurs during the eval phase, because npu.BoolTensor and npu.LongTensor are not supported in instane_data.py.
Modification
Modify the instane_data.py file to support NPU BoolTensor and LongTensor.
BC-breaking (Optional)
Not affected.
Use cases (Optional)
Not affected.