Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] when log_with_hierarchy is True, the running error appears in _collect_scalars for log processor #1085

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

HAOCHENYE
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fix #1082

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@HAOCHENYE HAOCHENYE changed the title [Fix] Fix log processor [Fix] when log_with_hierarchy is True, the running error appears in _collect_scalars for log processor Apr 19, 2023
@HAOCHENYE HAOCHENYE changed the title [Fix] when log_with_hierarchy is True, the running error appears in _collect_scalars for log processor [Fix] when log_with_hierarchy is True, the running error appears in _collect_scalars for log processor Apr 19, 2023
@zhouzaida zhouzaida merged commit be347df into open-mmlab:main Apr 20, 2023
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@a7d4b7c). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1085   +/-   ##
=======================================
  Coverage        ?   76.27%           
=======================================
  Files           ?      139           
  Lines           ?    11239           
  Branches        ?     2262           
=======================================
  Hits            ?     8572           
  Misses          ?     2303           
  Partials        ?      364           
Flag Coverage Δ
unittests 76.27% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] when log_with_hierarchy is True, the running error appears in _collect_scalars for log processor
2 participants