Refine the error message when auto_scale_lr is not set correctly #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-soare
requested review from
zhouzaida,
RangiLyu and
HAOCHENYE
as code owners
|
|
zhouzaida
previously approved these changes
Jun 2, 2023
zhouzaida
reviewed
Jun 2, 2023
alexander-soare
commented
Jun 2, 2023
Co-authored-by: Alexander Soare <alexander.soare159@gmail.com>
zhouzaida
changed the title
zhouzaida
reviewed
Jun 5, 2023
zhouzaida
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
RuntimeError when attempting to resume a run. It seems the logic for triggering the runtime error is incorrect (or the error message is incorrect, but this PR is based on the assumption that the error message is correct).
Modification
Remove a
notto fix the logic. This makes the RuntimeError trigger ifself.auto_scale_lrhas a key called "enable" and that key isTrue. This is the desired logic if we consider the error message which asks the user to set "enable" toFalseto avoid the error.Checklist
I did this in 30 seconds so admittedly I haven't followed the checklist. I'd be happy to file an issue and allow a core maintainer to carry on from here. Please let me know.