[Fix] Use get instead of pop to dump runner_type
#549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nijkah
changed the title
get instead of pop to get runner_typeget instead of pop to dump runner_type
nijkah
changed the title
get instead of pop to dump runner_typeget instead of pop to dump runner_type
|
LGTM. |
HAOCHENYE
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When using a custom runner,
runner_typeis not dumped appropriately, sincebuild_runner_from_cfgfunction pops therunner_type.To reproduce the experiment, it seems better to dump
runner_typetoo.mmengine/mmengine/registry/build_functions.py
Line 179 in 8d14eb6