-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Fix open() encoding problem of Config in Windows #648
Conversation
@zhouzaida Should we force using utf-8 to decode the config file? |
We should do that, it has been done in other places actually. |
mmengine/mmengine/config/config.py Line 421 in 6178ef2
mmengine/mmengine/config/config.py Line 553 in 6178ef2
These lines should also be refined. |
OK, I create a PR #653 |
* fix open in windows * Update config.py * Update config.py * Update config.py
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
fix the issue
#647
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist