Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualizer.draw_polygons examples wrong #798

Merged
merged 3 commits into from
Dec 8, 2022

Conversation

lyviva
Copy link
Contributor

@lyviva lyviva commented Dec 7, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Examples are out of data, so update.

Modification

According to the latest 'Visualizer.draw_polygons', fix them.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

Thanks, learn more.
solve "lint failed"
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Base: 78.66% // Head: 78.66% // No change to project coverage 👍

Coverage data is based on head (108a002) compared to base (fe26c65).
Patch has no changes to coverable lines.

❗ Current head 108a002 differs from pull request most recent head 58de421. Consider uploading reports for the commit 58de421 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #798   +/-   ##
=======================================
  Coverage   78.66%   78.66%           
=======================================
  Files         128      128           
  Lines        9348     9348           
  Branches     1848     1848           
=======================================
  Hits         7354     7354           
  Misses       1679     1679           
  Partials      315      315           
Flag Coverage Δ
unittests 78.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmengine/visualization/visualizer.py 93.19% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhouzaida zhouzaida merged commit 57f6644 into open-mmlab:main Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants