Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix MessageHub set resumed key repeatedly #839

Merged
merged 4 commits into from
Dec 20, 2022

Conversation

HAOCHENYE
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fix MessageHub.update_info set resumed key twice.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

zhouzaida
zhouzaida previously approved these changes Dec 20, 2022
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 78.66% // Head: 78.86% // Increases project coverage by +0.19% 🎉

Coverage data is based on head (9567c25) compared to base (fe26c65).
Patch coverage: 46.42% of modified lines in pull request are covered.

❗ Current head 9567c25 differs from pull request most recent head 18d030e. Consider uploading reports for the commit 18d030e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #839      +/-   ##
==========================================
+ Coverage   78.66%   78.86%   +0.19%     
==========================================
  Files         128      128              
  Lines        9348     9368      +20     
  Branches     1848     1858      +10     
==========================================
+ Hits         7354     7388      +34     
+ Misses       1679     1666      -13     
+ Partials      315      314       -1     
Flag Coverage Δ
unittests 78.86% <46.42%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmengine/optim/optimizer/zero_optimizer.py 52.17% <0.00%> (-4.97%) ⬇️
mmengine/registry/build_functions.py 80.20% <ø> (ø)
mmengine/registry/default_scope.py 100.00% <ø> (ø)
mmengine/visualization/vis_backend.py 84.49% <ø> (ø)
mmengine/visualization/visualizer.py 93.19% <ø> (ø)
mmengine/runner/checkpoint.py 52.07% <11.11%> (+8.11%) ⬆️
mmengine/model/weight_init.py 35.63% <33.33%> (+0.12%) ⬆️
mmengine/optim/optimizer/optimizer_wrapper.py 62.06% <71.42%> (-0.44%) ⬇️
mmengine/logging/message_hub.py 94.95% <100.00%> (-0.13%) ⬇️
mmengine/optim/optimizer/default_constructor.py 98.27% <100.00%> (+0.04%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhouzaida zhouzaida merged commit 2eede1b into open-mmlab:main Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants