Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix the bug when the params in shared modules do not require grad #903

Merged
merged 2 commits into from
Feb 15, 2023
Merged

[Bug] Fix the bug when the params in shared modules do not require grad #903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bad1c33
fix the bug when the params in shared modules do not require grad
HIT-cwh Feb 3, 2023
e807e8b
test DefaultOptimWrapperConstructor when the params in shared modules…
HIT-cwh Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions mmengine/optim/optimizer/default_constructor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,13 +204,14 @@ def add_params(self,

for name, param in module.named_parameters(recurse=False):
param_group = {'params': [param]}
if not param.requires_grad:
params.append(param_group)
continue
if bypass_duplicate and self._is_in(param_group, params):
warnings.warn(f'{prefix} is duplicate. It is skipped since '
f'bypass_duplicate={bypass_duplicate}')
continue
if not param.requires_grad:
params.append(param_group)
continue

# if the parameter match one of the custom keys, ignore other rules
is_custom = False
for key in sorted_keys:
Expand Down
15 changes: 15 additions & 0 deletions tests/test_optim/test_optimizer/test_optimizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,6 +576,21 @@ def test_default_optimizer_constructor_bypass_duplicate(self):
self._check_sgd_optimizer(optim_wrapper.optimizer, model,
**paramwise_cfg)

# test DefaultOptimWrapperConstructor when the params in shared
# modules do not require grad
model.conv1[0].requires_grad_(False)
self.assertWarnsRegex(
Warning,
'conv3.0 is duplicate. It is skipped since bypass_duplicate=True',
lambda: optim_constructor(model))
optim_wrapper = optim_constructor(model)
model_parameters = list(model.parameters())
num_params = 14 if MMCV_FULL_AVAILABLE else 11
assert len(optim_wrapper.optimizer.param_groups) == len(
model_parameters) == num_params
self._check_sgd_optimizer(optim_wrapper.optimizer, model,
**paramwise_cfg)

def test_default_optimizer_constructor_custom_key(self):
# test DefaultOptimWrapperConstructor with custom_keys and
# ExampleModel
Expand Down