Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Feature NPUProfilerHook #925

Merged
merged 2 commits into from
Feb 21, 2023
Merged

[Feature] Feature NPUProfilerHook #925

merged 2 commits into from
Feb 21, 2023

Conversation

luomaoling
Copy link
Contributor

@luomaoling luomaoling commented Feb 13, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Added NPUProfilerHook class.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
No.

Use cases (Optional)

cfg = Config.fromfile(args.config) 
profiler_config = [dict(type='NPUProfilerHook', result_path='./cann_profiling')]
cfg.merge_from_dict({'custom_hooks': profiler_config })
runner = Runner.from_cfg(cfg)

Export timeline data
python /usr/local/Ascend/ascend-toolkit/latest/toolkit/tools/profiler/profiler_tool/analysis/msprof/msprof.py export timeline -dir ./cann_profiling

Export summary data
python /usr/local/Ascend/ascend-toolkit/latest/toolkit/tools/profiler/profiler_tool/analysis/msprof/msprof.py export summary -dir ./cann_profiling

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@luomaoling luomaoling changed the title Feature NPUProfilerHook [Feature] Feature NPUProfilerHook Feb 17, 2023
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@c712070). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head beb3fb9 differs from pull request most recent head ce099f9. Consider uploading reports for the commit ce099f9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #925   +/-   ##
=======================================
  Coverage        ?   76.66%           
=======================================
  Files           ?      138           
  Lines           ?    10827           
  Branches        ?     2162           
=======================================
  Hits            ?     8301           
  Misses          ?     2168           
  Partials        ?      358           
Flag Coverage Δ
unittests 76.66% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhouzaida zhouzaida merged commit 3dc2be0 into open-mmlab:main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants