Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix inferencer gets wrong configs path #996

Merged
merged 14 commits into from
Mar 14, 2023

Conversation

HAOCHENYE
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fix inferencer get wrong configs path.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

zhouzaida
zhouzaida previously approved these changes Mar 14, 2023
@zhouzaida zhouzaida changed the title [Fix] Fix inferencer get wrong configs path [Fix] Fix inferencer gets wrong configs path Mar 14, 2023
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@789330e). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head f50d3b9 differs from pull request most recent head ba916e2. Consider uploading reports for the commit ba916e2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #996   +/-   ##
=======================================
  Coverage        ?   76.57%           
=======================================
  Files           ?      139           
  Lines           ?    11037           
  Branches        ?     2207           
=======================================
  Hits            ?     8452           
  Misses          ?     2219           
  Partials        ?      366           
Flag Coverage Δ
unittests 76.57% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

.circleci/test.yml Outdated Show resolved Hide resolved
@zhouzaida zhouzaida merged commit ad33a7d into open-mmlab:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants